Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove installing netcat and openjdk-11-jdk #449

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

kaiyan-sheng
Copy link
Contributor

What does this PR do?

This PR is to remove netcat and openjdk-11-jdk installation to fix make docker-lint error:

 => ERROR [ 2/14] RUN apt-get -qq update && apt-get -qq -y --no-install-recommends install     ca-certificates     curl     docker.io     libsasl2-dev     netcat     openjdk-11-jdk     sudo     zip &&    rm -r  2.9s
------
 > [ 2/14] RUN apt-get -qq update && apt-get -qq -y --no-install-recommends install     ca-certificates     curl     docker.io     libsasl2-dev     netcat     openjdk-11-jdk     sudo     zip &&    rm -rf /var/lib/apt/lists/*:
2.886 E: Package 'netcat' has no installation candidate
2.886 E: Unable to locate package openjdk-11-jdk
------
Dockerfile:4
--------------------
   3 |     
   4 | >>> RUN apt-get -qq update && apt-get -qq -y --no-install-recommends install \
   5 | >>>     ca-certificates \
   6 | >>>     curl \
   7 | >>>     docker.io \
   8 | >>>     libsasl2-dev \
   9 | >>>     netcat \
  10 | >>>     openjdk-11-jdk \
  11 | >>>     sudo \
  12 | >>>     zip &&\
  13 | >>>     rm -rf /var/lib/apt/lists/*
  14 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c apt-get -qq update && apt-get -qq -y --no-install-recommends install     ca-certificates     curl     docker.io     libsasl2-dev     netcat     openjdk-11-jdk     sudo     zip &&    rm -rf /var/lib/apt/lists/*" did not complete successfully: exit code: 100
make: *** [flake8] Error 1

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

File Coverage Lines Branches Missing
All files 100% 100% 100%
main_aws.py 100% 100% 100%
handlers/__init__.py 100% 100% 100%
handlers/aws/__init__.py 100% 100% 100%
handlers/aws/cloudwatch_logs_trigger.py 100% 100% 100%
handlers/aws/exceptions.py 100% 100% 100%
handlers/aws/handler.py 100% 100% 100%
handlers/aws/kinesis_trigger.py 100% 100% 100%
handlers/aws/replay_trigger.py 100% 100% 100%
handlers/aws/s3_sqs_trigger.py 100% 100% 100%
handlers/aws/sqs_trigger.py 100% 100% 100%
handlers/aws/utils.py 100% 100% 100%
share/__init__.py 100% 100% 100%
share/config.py 100% 100% 100%
share/events.py 100% 100% 100%
share/expand_event_list_from_field.py 100% 100% 100%
share/factory.py 100% 100% 100%
share/include_exlude.py 100% 100% 100%
share/json.py 100% 100% 100%
share/logger.py 100% 100% 100%
share/multiline.py 100% 100% 100%
share/secretsmanager.py 100% 100% 100%
share/utils.py 100% 100% 100%
shippers/__init__.py 100% 100% 100%
shippers/composite.py 100% 100% 100%
shippers/es.py 100% 100% 100%
shippers/factory.py 100% 100% 100%
shippers/logstash.py 100% 100% 100%
shippers/shipper.py 100% 100% 100%
storage/__init__.py 100% 100% 100%
storage/decorator.py 100% 100% 100%
storage/factory.py 100% 100% 100%
storage/payload.py 100% 100% 100%
storage/s3.py 100% 100% 100%
storage/storage.py 100% 100% 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against db36c2d

@kaiyan-sheng kaiyan-sheng self-assigned this Aug 2, 2023
@endorama
Copy link
Member

endorama commented Aug 3, 2023

We should really not build images on the fly but have them pre-built, so we avoid this kind of errors. I opened a follow-up issue to track this #450

@kaiyan-sheng kaiyan-sheng merged commit 02ffcfd into elastic:main Aug 3, 2023
@kaiyan-sheng kaiyan-sheng deleted the fix_docker_lint branch August 3, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants